Bug 16482 - Please add four more LAPACK functions to Rlapack
Summary: Please add four more LAPACK functions to Rlapack
Status: CLOSED FIXED
Alias: None
Product: R
Classification: Unclassified
Component: Add-ons (show other bugs)
Version: R-devel (trunk)
Hardware: Other Linux
: P5 enhancement
Assignee: R-core
URL:
Depends on:
Blocks:
 
Reported: 2015-07-22 02:07 UTC by Dirk Eddelbuettel
Modified: 2017-09-01 14:32 UTC (History)
2 users (show)

See Also:


Attachments
Update Rlapack to include zgges, zgetri, and zgels (238.41 KB, patch)
2015-07-28 02:52 UTC, Keith O'Hara
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Eddelbuettel 2015-07-22 02:07:21 UTC
Armadillo received a contribution for qz().  I would like to expose this in RcppArmadillo, and can when we have a feature-full LAPACK (eg on Linux or OS X when extern LAPACK is used).

On Windows, and other systems with Rlapack, Armadillo would need

   sgges, dgges, cgges, zgges

As with prior practive 's*' and 'c*' are not going to be used by R, but maybe dgges and zgges could be included in time for R 3.3 ?

I could try and help with a patch if you'd want me to.
Comment 1 Martin Maechler 2015-07-22 07:25:31 UTC
Sounds reasonable to me.... notably if you provide a patch (against R-devel),
including appropriate changes to

  src/include/R_ext/Lapack.h
  src/modules/lapack/README  (needs updating; contains other files to consider)
Comment 2 Dirk Eddelbuettel 2015-07-22 17:13:50 UTC
Also, from more discussion with Conrad and Keith, we'd want

  zgetri
  zgels

and with that the Subject of the bug report is back in line.
Comment 3 Keith O'Hara 2015-07-28 02:52:36 UTC
Created attachment 1860 [details]
Update Rlapack to include zgges, zgetri, and zgels

This should add the functionality that Dirk mentioned. Changes were made to 

src/include/R_ext/Lapack.h 
src/modules/lapack/cmplx.f
src/modules/lapack/README

zgges required a total of 13 additional LAPACK routines; zgetri and zgels only needed 3 and 1 additions (resp.).
Comment 4 Keith O'Hara 2015-08-21 16:53:17 UTC
(In reply to Martin Maechler from comment #1)
> Sounds reasonable to me.... notably if you provide a patch (against R-devel),
> including appropriate changes to
> 
>   src/include/R_ext/Lapack.h
>   src/modules/lapack/README  (needs updating; contains other files to
> consider)

Is there anything additional we need to provide for this?
Comment 5 Keith O'Hara 2015-12-12 17:57:27 UTC
Bump...
Comment 6 Dirk Eddelbuettel 2017-09-01 14:32:26 UTC
This was done a while back.  So thanks!